Theme code review: what to look for
A review that produces forty comments produced nothing. Automate the nitpicks, then spend human attention on blast radius, Liquid cost and who owns the setting.
CATEGORY
Everything we have written on theme & liquid — 8 posts, newest first.
A review that produces forty comments produced nothing. Automate the nitpicks, then spend human attention on blast radius, Liquid cost and who owns the setting.
The argument has nothing to do with users who disable JavaScript. It is about the ordinary minutes when a script is late, blocked or broken — and whether your add to cart still works.
A theme refactor is the project nobody will fund, because it produces no screenshot. Done in the right order it is also the one that makes every later change cheaper.
A Shopify theme already has a token layer — theme settings, colour scheme groups and font settings. The work is deciding which tokens the merchant owns, not building a pipeline.
Changing the architecture and keeping the design is a legitimate project, and a harder sell than a redesign. It is also the one that pays back.
A setting is a question you are asking a colleague at four o’clock on a Friday. Most theme settings are a developer thinking aloud.
Nested loops, metafields inside iterations, and filters recomputed 200 times. The patterns that make a theme slow on the server — and why that is usually not your worst problem.
Sections, blocks and settings each solve a different problem. Using the wrong one is how a theme becomes unmaintainable.
NEXT STEP
A senior Shopify engineer reviews your storefront, theme performance and checkout, then sends a prioritised list of fixes.